-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Views::Inline #100
Merged
Merged
Add Views::Inline #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @asajeffrey |
3 tasks
Manishearth
force-pushed
the
inline
branch
2 times, most recently
from
December 6, 2019 00:04
5647957
to
08f1be2
Compare
asajeffrey
approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bors-servo r=asajeffrey |
📌 Commit 08f1be2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 6, 2019
Add Views::Inline For inline sessions the client should be doing all the calculations. servo side: servo/servo#25144
💔 Test failed - checks-travis |
@bors-servo r=asajeffrey |
📌 Commit 82e70c0 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 6, 2019
Add Views::Inline For inline sessions the client should be doing all the calculations. servo side: servo/servo#25144
☀️ Test successful - checks-travis |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 6, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 6, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 11, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 11, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 11, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 11, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 11, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 12, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 12, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 12, 2019
Support inline sessions (with spatial tracking!) This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 . Todo: - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101) - [x] WPT update - [ ] Make inline with spatial tracking a feature request (followup: #24270) fixes #24186 Depends on servo/webxr#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For inline sessions the client should be doing all the calculations.
servo side: servo/servo#25144